Skip to content

introduce variable to control Amavis' loglevel#1947

Merged
georglauterbach merged 5 commits intodocker-mailserver:masterfrom
georglauterbach:amavis_loglevel
May 6, 2021
Merged

introduce variable to control Amavis' loglevel#1947
georglauterbach merged 5 commits intodocker-mailserver:masterfrom
georglauterbach:amavis_loglevel

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented May 6, 2021

Description

Introduced AMAVIS_LOGLEVEL variable to control the log level. This way, one can control the verbositoy of Amavis. This can be of special importance when users post logs (for the first time) as they always post the (huge) Amavis log too. See #1944.

This is a "breaking" change, as the default of 0 (= warning) is new. We can merge this before releasing 10.0.0. I can test this feature in my setup for a week if necessary,

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or ENVIRONMENT.md or the documentation)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added priority/low area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels May 6, 2021
@georglauterbach georglauterbach requested a review from a team May 6, 2021 12:53
@georglauterbach georglauterbach self-assigned this May 6, 2021
@casperklein
Copy link
Copy Markdown
Member

Please add the information provided in ENVIRONMENT.md also to mailserver.env.

Besides that, the rest looks good to me.

We can merge this before releasing 10.0.0.

Definitely. The more breaking changes, the better 😉 So we don't have to release that often major releases.

@georglauterbach
Copy link
Copy Markdown
Member Author

Good point. I've added the variable to mailserver.env. This is then ready to be merged :)

Comment thread target/scripts/startup/setup-stack.sh
@georglauterbach georglauterbach merged commit 04e98dc into docker-mailserver:master May 6, 2021
@georglauterbach georglauterbach deleted the amavis_loglevel branch May 6, 2021 21:51
@wernerfred wernerfred added this to the v10.0.0 milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants