Skip to content

Add supervisord stop grace period#1945

Merged
casperklein merged 1 commit intomasterfrom
casperklein-patch-1
May 6, 2021
Merged

Add supervisord stop grace period#1945
casperklein merged 1 commit intomasterfrom
casperklein-patch-1

Conversation

@casperklein
Copy link
Copy Markdown
Member

Description

Follow up for #1896. Increasing docker-compose stop grace period to 1 minute was pretty pointless, because supervisord also sends a SIGKILL after 10 seconds. This adds a stop grace period to supervisord also.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or ENVIRONMENT.md or the documentation)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein requested a review from a team May 6, 2021 10:12
@casperklein casperklein self-assigned this May 6, 2021
@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels May 6, 2021
@casperklein casperklein merged commit ba37ed1 into master May 6, 2021
@casperklein casperklein deleted the casperklein-patch-1 branch May 6, 2021 17:04
@wernerfred wernerfred added this to the v10.0.0 milestone May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants