Skip to content

Fail2Ban block behaviour#1914

Merged
casperklein merged 8 commits intodocker-mailserver:masterfrom
casperklein:fail2ban
Apr 18, 2021
Merged

Fail2Ban block behaviour#1914
casperklein merged 8 commits intodocker-mailserver:masterfrom
casperklein:fail2ban

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Apr 16, 2021

Description

Further work from #1821.

  • Introduce FAIL2BAN_BLOCKTYPE
    drop => drop packet (send NO reply)
    reject => reject packet (send ICMP unreachable)

  • Block IP for all ports now. The old behavior was to block the IP only for the affected port/service. This can be reverted via config/fail2ban-jail.cf

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or ENVIRONMENT.md or the documentation)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein changed the title Fail2ban Fail2ban blocking behaviour Apr 16, 2021
@casperklein casperklein changed the title Fail2ban blocking behaviour Fail2Ban blocking behaviour Apr 16, 2021
@casperklein casperklein changed the title Fail2Ban blocking behaviour Fail2Ban block behaviour Apr 16, 2021
@casperklein casperklein self-assigned this Apr 16, 2021
@casperklein casperklein added area/enhancement area/features kind/improvement Improve an existing feature, configuration file or the documentation kind/new feature A new feature is requested in this issue or implemeted with this PR labels Apr 16, 2021
@casperklein casperklein marked this pull request as ready for review April 17, 2021 00:26
@casperklein casperklein requested a review from a team April 17, 2021 00:26
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casperklein casperklein merged commit f7836c8 into docker-mailserver:master Apr 18, 2021
@casperklein casperklein deleted the fail2ban branch April 18, 2021 14:29
@wernerfred wernerfred added this to the v10.0.0 milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/features kind/improvement Improve an existing feature, configuration file or the documentation kind/new feature A new feature is requested in this issue or implemeted with this PR service/security/fail2ban

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants