Enhance setup.sh email list#1898
Conversation
wernerfred
left a comment
There was a problem hiding this comment.
How does the output look like if there is no quota enabled/set?
There should be no line with |
Like in the provided example. The aliases line is only shown when there are aliases configured. |
|
@casperklein this PR introduced a regression as identified via Comment support for this utility was previously implemented via this PR with the line: (grep -v "^\s*$\|^\s*\#" "$DATABASE" || true) | awk -F '|' '{ print $1; }'But your changes appear to have broken that? I think we could add a test (I don't mind writing the test), to check that the output doesn't contain the comments to avoid this in future? |
|
This regression should be an easy fix though, right? Just re-adding the |
I assume so? I am working on a PR to merge for # Remove string input with only whitespace or `#` as the first non-whitespace character.
function _strip_comments
{
grep -q -E "^\s*$|^\s*#" <<< "${1}"
} |
I like it 👍🏼 |
Description
Display an enhanced all-in-one ./setup.sh email list with quotas, disk usage and aliases for each user with one single command.
The ./setup.sh email list command output looks like this :
Implements #1892
Type of change
Checklist: