Skip to content

Add stop grace period#1896

Merged
georglauterbach merged 1 commit intomasterfrom
casperklein-patch-1
Apr 11, 2021
Merged

Add stop grace period#1896
georglauterbach merged 1 commit intomasterfrom
casperklein-patch-1

Conversation

@casperklein
Copy link
Copy Markdown
Member

Description

It's always best practice, to shutdown services graceful. docker-compose down/stop sends SIGKILL after 10 seconds. In some environments, this is not enough time for the services to stop.

docker-compose will now wait up to 1 minute before sending SIGKILL, which should be enough time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or ENVIRONMENT.md or the documentation)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added area/enhancement kind/improvement Improve an existing feature, configuration file or the documentation labels Apr 11, 2021
@casperklein casperklein requested a review from a team April 11, 2021 00:24
@casperklein casperklein self-assigned this Apr 11, 2021
@georglauterbach georglauterbach merged commit 004825e into master Apr 11, 2021
@georglauterbach georglauterbach deleted the casperklein-patch-1 branch April 11, 2021 12:51
@casperklein casperklein mentioned this pull request May 6, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants