Skip to content

setup.sh improved#1886

Merged
casperklein merged 4 commits intodocker-mailserver:masterfrom
casperklein:setup.sh-improvement
Apr 7, 2021
Merged

setup.sh improved#1886
casperklein merged 4 commits intodocker-mailserver:masterfrom
casperklein:setup.sh-improvement

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Apr 6, 2021 •
edited
Loading

Description

  • EXIT trap removed
  • _unset_vars function removed
  • _get_current_directory function replaced with simpler approach
  • variable list ordered
  • renamed USING_SELINUX to USE_SELINUX like the rest of the USE_ stuff.

Partly discussed here: #1885

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or ENVIRONMENT.md or the documentation)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein requested a review from a team April 6, 2021 15:07
@casperklein casperklein added area/enhancement area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Apr 6, 2021
wernerfred
wernerfred reviewed Apr 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as you removed a function we can safely decrease the image version number 🃏 🤣

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Apr 6, 2021

Absolutely 😆

@casperklein casperklein marked this pull request as draft April 6, 2021 16:46
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Apr 6, 2021

Probably we cannot get rid of _get_current_directory, because we need an absolute path for docker -v command.

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Apr 6, 2021 •
edited
Loading

Probably we cannot get rid of _get_current_directory, because we need an absolute path for docker -v command.

🤣 so there it was, the need for an absolute path, hiding in plain site.

@casperklein casperklein marked this pull request as ready for review April 6, 2021 18:27
@casperklein casperklein merged commit c7a798b into docker-mailserver:master Apr 7, 2021
@wernerfred wernerfred mentioned this pull request Apr 8, 2021
Closed
@casperklein casperklein deleted the setup.sh-improvement branch April 11, 2021 15:41
@wernerfred wernerfred added this to the v10.0.0 milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wernerfred wernerfred wernerfred approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

No one assigned

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @georglauterbach @wernerfred