Skip to content

yaml base-60 float warning added#1859

Merged
georglauterbach merged 1 commit intomasterfrom
casperklein-patch-1
Mar 23, 2021
Merged

yaml base-60 float warning added#1859
georglauterbach merged 1 commit intomasterfrom
casperklein-patch-1

Conversation

@casperklein
Copy link
Copy Markdown
Member

Description

Removing the quotation marks in the docker-compose port section, can lead to unexpected behaviour.

More Information:

Fixes #1858 and other similar

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or ENVIRONMENT.md or the Wiki)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach enabled auto-merge (squash) March 22, 2021 20:01
@wernerfred
Copy link
Copy Markdown
Member

Glad this one came up early. I need to find a solution for that required status checks if no build relevant files are touched. I am disabling the requirement for now and think of a solution in the meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incoming e-mails from external servers are not received

3 participants