So

echo "Mailbox deleted." || errex "Mailbox couldn't be deleted: ${?}"

is obviously hilarious. The tests however do not seem to like

if [[ -d "/var/mail/${MAILARR[1]}/${MAILARR[0]}" ]]
then
  ...
else
  errex "Mailbox directory '/var/mail/${MAILARR[1]}/${MAILARR[0]}' does not exist." # <- especially this
fi

which before would not be exiting with a non-zero exit code. I would just change this to

if [[ -d "/var/mail/${MAILARR[1]}/${MAILARR[0]}" ]]
then
  ...
else
  echo "Mailbox directory '/var/mail/${MAILARR[1]}/${MAILARR[0]}' did not exist."
fi

@wernerfred Your take? Ima be honest here, not sure if the tests are written to conform to the shitty script...?

PS: I just did it and I will see how it turns out.

@wernerfred Your take? Ima be honest here, not sure if the tests are written to conform to the shitty script...?

Speaking directly (no offense to the original test writers) for me it was really hard to understand what's going on with a lot of the tests I examined as I had to patch a test for the dkim PR. There are a lot of tests where calling them bad style would be too nice. Sometimes the authors even stated in the comments above that the test is really crap and will propably also pass if something else is given as ENV (testing only wc -l ). Imho there would be a major refactoring necessary. Also there is a huge wild growth of configuration dirs and configs as every test author approached it a bit different. We should also consider writing a How-To about the tests as it is really hard to get into it from a outside perspective.

echo "Mailbox deleted." || errex "Mailbox couldn't be deleted: ${?}"

🤣 🤣 🤣

@wernerfred Your take? Ima be honest here, not sure if the tests are written to conform to the shitty script...?

Speaking directly (no offense to the original test writers) for me it was really hard to understand what's going on with a lot of the tests I examined as I had to patch a test for the dkim PR. There are a lot of tests where calling them bad style would be too nice. Sometimes the authors even stated in the comments above that the test is really crap and will propably also pass if something else is given as ENV (testing only wc -l ). Imho there would be a major refactoring necessary. Also there is a huge wild growth of configuration dirs and configs as every test author approached it a bit different. We should also consider writing a How-To about the tests as it is really hard to get into it from a outside perspective.

Indeed, the tests will need complete overhaul in the future.

echo "Mailbox deleted." || errex "Mailbox couldn't be deleted: ${?}"

rofl rofl rofl

I didn't even see this the first time, but when I saw it, I was perplexed...

Tests are passing now. This is ready for merging, only waiting for your review.