Skip to content

Enhancement for function _setup_postfix_sasl fixing #1796 & More#1798

Merged
georglauterbach merged 1 commit intodocker-mailserver:masterfrom
georglauterbach:fix#1796
Feb 8, 2021
Merged

Enhancement for function _setup_postfix_sasl fixing #1796 & More#1798
georglauterbach merged 1 commit intodocker-mailserver:masterfrom
georglauterbach:fix#1796

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Feb 7, 2021

Description

SASL is now disabled correctly. The Dockerfile has been adjusted to not show the delaying debconf because apt-utils is not installed error anymore. function _misc_save_states was refactored too as it was in an unacceptable state. Especially proud of the inline variable substitutions that got rid of echo ... | sed ....

Fixes #1796

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or ENVIRONMENT.md or the Wiki)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

PS: I like the new template :D

@wernerfred
Copy link
Copy Markdown
Member

PS: I like the new template :D

🥳

My hope is that people get motivated providing some more information than they would without it

Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georglauterbach georglauterbach merged commit 5338433 into docker-mailserver:master Feb 8, 2021
@georglauterbach georglauterbach deleted the fix#1796 branch February 8, 2021 10:38
Comment thread target/scripts/start-mailserver.sh
Comment thread target/scripts/start-mailserver.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] SASL is enabled with ENABLE_SASLAUTHD=0 but only when SMTP_ONLY=1

3 participants