Skip to content

FIX: build inconsistencies for razor#1756

Merged
georglauterbach merged 1 commit intodocker-mailserver:masterfrom
georglauterbach:fix-build_inconsistency
Jan 20, 2021
Merged

FIX: build inconsistencies for razor#1756
georglauterbach merged 1 commit intodocker-mailserver:masterfrom
georglauterbach:fix-build_inconsistency

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an ugly workaround for such a simple line of code. Don't get me wrong I'm not complaining about your code - more than the fact that this is necessary 😒

LGTM tho as the action will hopefully pass now constantly (remains unclear if the fix will kick in or it will be just random again)

@casperklein
Copy link
Copy Markdown
Member

@aendeavor

Out of interest, did you try the variant with two RUN statements?

@georglauterbach
Copy link
Copy Markdown
Member Author

@aendeavor

Out of interest, did you try the variant with two RUN statements?

I actually didn't. I was considering it, but now I'm not sure about this anymore, since the error we're seeing is most likely yet not related to the two command's sequence, but to the second command having a network error of some sort. This will ultimately not be fixed with different positions in the Dockerfile, but by retrying.

Does that sound logical? What's your take?

@georglauterbach georglauterbach changed the title Should fix build inconsistencies for razor FIX: build inconsistencies for razor Jan 20, 2021
@casperklein
Copy link
Copy Markdown
Member

casperklein commented Jan 20, 2021

I didn't fully get what the root cause of the problem actually is. All my local builds were successful, even with the sleep command completely removed. I had never problems with the register command, so wondering why the GH CI fails.

Do we know, why razor-admin -register exactly fails? Is there some error output?
Typically a sleep is needed, when for example a daemon is started, that needs some time to startup and open a port. But that shouldn't be the case with razor-admin -register? At the moment, we are retrying 10 times in the hope it succeed. If we know the root cause why it fails, maybe we are able to fix it a better way, instead of just "dumb" retrying.

The retry approach is ugly, but obviously needed for the Github CI, if we don't want to deal with failed builds from time to time. So for now, I am fine with this fix. 👍

@georglauterbach
Copy link
Copy Markdown
Member Author

Do we know, why razor-admin -register exactly fails? Is there some error output?

When you execute it locally before razor-admin -create was called, you'll see an error reported with exit code 2 - I guess this is what we're seeing. However, retrying is in this case the best approach since it's a CI inconsistency:)

@georglauterbach georglauterbach merged commit 035c4de into docker-mailserver:master Jan 20, 2021
@georglauterbach georglauterbach deleted the fix-build_inconsistency branch January 20, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants