Allow manual domains for dkim generator#1736
Allow manual domains for dkim generator#1736williamdes wants to merge 2 commits intodocker-mailserver:masterfrom williamdes:ldap-dkim-generator
Conversation
georglauterbach
left a comment
georglauterbach
left a comment
There was a problem hiding this comment.
Looks very fine to me. Please only adjust the setup.sh script as I suggested.
|
It should be okay, I did script that without testing it and if the bats tests passes, then it is okay. I will test it but for now I am working on ldap domains |
|
I have now corrected the scripts myself as there was a syntax error and a misuse of |
|
Looks like I should add back the volume mounts like the test that I copied it from |
|
Not sure whether that fixes the |
|
No more errors but tests fail Looks like the domains option does not work or something else |
|
That's unfortunate - but we'll need to see all tests passing before merging this PR. I guess some more debugging needs to be done here. |
|
This should work now, |
|
F*** 😄 |
|
You could try getting a free account at docker
That should remove the amount of pulls.
Kind regardst,
Roy van der Linden
Certified Data Protection Officer DPCDPO1026251-2018-01
TechGourmet
Communication Consultancy
Dit bericht is alleen bestemd voor de geaddresseerde en kan informatie bevatten die privé, vertrouwelijk of anderszins niet
openbaar mag worden gemaakt. In de lezer niet de beoogde ontvanger van dit bericht is, wordt deze hierbij geinformeerd dat
de informatie in dit bericht niet gekopieerd of anderszins verspreidt mag worden. Tevens wordt u hierbij verzocht om ons hiervan
direct op de hoogte te stellen en het bericht aan ons te retourneren. Bij voorbaat dank voor uw medewerking.
… On 3 Jan 2021, at 14:56, 'William Desportes' via TechGourmet Support ***@***.***> wrote:
F***
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Well, the tests will run another day..
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#1736 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEHODWD6DLH2GZC74WMFYT3SYBZQ5ANCNFSM4VQ7GXUA>.
|
|
Closed due to migration to docker-mailserver/docker-mailserver. Please re-open over there :D |
3 participants
Fix #1735 - The dkim key generator does not work for ldap setups