Skip to content

Get rid of syslogd warnings about kernel logging.#1711

Merged
erik-wramner merged 3 commits intodocker-mailserver:masterfrom
MakerMatrix:rsyslog-ikmlog-fix
Dec 18, 2020
Merged

Get rid of syslogd warnings about kernel logging.#1711
erik-wramner merged 3 commits intodocker-mailserver:masterfrom
MakerMatrix:rsyslog-ikmlog-fix

Conversation

@MakerMatrix
Copy link
Copy Markdown
Contributor

  • Modify Dockerfile to comment out noisy/errant kernel logging line in /etc/rsyslogd.conf
  • Add lines in README.md that prompt users to create an alias that captures messages to postmaster.
  • Add commented line in /etc/postfix/main.cf to easily set 'myorigin=$mydomain' if desired. Then e.g. postmaster emails will be addressed from "[email protected]" instead of "[email protected]". This may require a regex or an additional or modified virtual alias for postfix to accept mail from such an address. I have not documented that in these patches. If people watch mail.log it will be clear.

@georglauterbach
Copy link
Copy Markdown
Member

Requested a review from @erik-wramner and @fbartels because I am not confidently review these changes - more on the script side myself:)

@georglauterbach
Copy link
Copy Markdown
Member

Damn it, the quota tests again. @martin-schulze-vireso this is the second time close after one another where this test fails. Seems like this hasn't been resolved after all...

@martin-schulze-vireso
Copy link
Copy Markdown
Contributor

It looks like a true failure. The second large mail should not have been delivered but we got a quota message on the third. I am not sure if there is some kind of race condition due to sending the mails too fast. However, that would likely be outside of our control to fix.

Maybe we should wait for the first mail to be delivered before sending the next one.

Comment thread target/postfix/main.cf Outdated
Comment thread Dockerfile
@georglauterbach
Copy link
Copy Markdown
Member

@martin-schulze-vireso you're right. But before doing that, I will see what the next test result bring, whether the quota test is "properly" failing or whether this is random as well.

Comment thread Dockerfile
sed -i -e 's/^\(POLICYHELPER=\).*/\1/' /usr/sbin/invoke-rc.d && \
# Prevent syslog warning about imklog permissions.
# We won't want to look at that inside a container anyway.
sed -i -e 's/^module(load=\"imklog\")/#module(load=\"imklog\")/' /etc/rsyslog.conf && \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the quotes do not need to be escaped:
sed -i -e 's/^module(load="imklog")/#module(load="imklog")/' /etc/rsyslog.conf && \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, @casperklein is correct. I overlooked that:)

@erik-wramner
Copy link
Copy Markdown
Contributor

I think this looks good. One thing though. Where we add the postmaster alias we could also add an alias for amavis.

There is another PR about adding both in the start script. @aendeavor I think we should either remove the postmaster alias from the readme in this PR and implement it in the other or we should add the amavis alias here. We could of course also do both and then remove the aliases from the readme later when the other PR has been released.

Comment thread README.md
@erik-wramner erik-wramner merged commit a2ebeea into docker-mailserver:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants