Small fixes for extracting certs from the acme.json file#1703
Merged
georglauterbach merged 3 commits intodocker-mailserver:masterfrom Dec 11, 2020
BrandonSchmitt:acme-fixes
Merged
Small fixes for extracting certs from the acme.json file#1703georglauterbach merged 3 commits intodocker-mailserver:masterfrom BrandonSchmitt:acme-fixes
georglauterbach merged 3 commits intodocker-mailserver:masterfrom
BrandonSchmitt:acme-fixes
Conversation
…f there are sections with null values as certs Signed-off-by: Brandon Schmitt <[email protected]>
…me.json during start-up Signed-off-by: Brandon Schmitt <[email protected]>
Member
|
Thank you for providing these fixes @BrandonSchmitt. I will happily merge this as soon as possible, but before I approve of these changes, I would like to take a look at the |
Member
|
EDIT: Sorry for the inconvenience, forgot to press the submit button for the review (here too). |
georglauterbach
approved these changes
Dec 11, 2020
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I wanted to setup TLS with certificates provided by traefik I ran into two small bugs:
The first was a python exception. I have an acme.json containing sections which look like:
The script didn't test if
Certificateswasnull.The second problem was that the environment variable
SSL_DOMAINwas only used while watching for changes in the acme.json, not during start-up.Both bugs are fixed with this PR.