Skip to content

Remove write access to group and others to Amavis configuration files#1632

Merged
erik-wramner merged 2 commits intodocker-mailserver:masterfrom
artonge:patch-1
Oct 6, 2020
Merged

Remove write access to group and others to Amavis configuration files#1632
erik-wramner merged 2 commits intodocker-mailserver:masterfrom
artonge:patch-1

Conversation

@artonge
Copy link
Copy Markdown
Contributor

@artonge artonge commented Oct 1, 2020

Remove write access to group and others to Amavis configuration files

Fix: #1446

Remove write access to group and others to Amavis configuration files

Fix: #1446
@georglauterbach
Copy link
Copy Markdown
Member

I will merge this, but I want to hear @erik-wramner opinion in #1446 first.

@erik-wramner
Copy link
Copy Markdown
Contributor

The chmod affects not only the copied files but any other files that happen to be in the folder as well. I would suggest another approach, see moby/moby#34263. It is now possible to set the permissions and owner in the COPY command in the Dockerfile. If we do that we save one layer in the final image and we don't risk changing existing files in a negative way.

@artonge, can you try that instead, please?

Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now possible to set the permissions and owner in the COPY command in the Dockerfile. If we do that we save one layer in the final image and we don't risk changing existing files in a negative way.

Exactly why I wanted to hear @erik-wramner on this. Thanks :D

@erik-wramner
Copy link
Copy Markdown
Contributor

Hm, chmod will be supported (moby/moby#34819) but is not there yet. I'll merge this then.

@erik-wramner erik-wramner merged commit c7135c2 into docker-mailserver:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amavis config file permissions not secure, keeps looping

3 participants