Complete refactoring for start-mailserver.sh#1605
Complete refactoring for start-mailserver.sh#1605georglauterbach merged 4 commits intodocker-mailserver:masterfrom georglauterbach:start_mailserver
start-mailserver.sh#1605Conversation
* included `start-mailserver` into shellcheck checks
|
I have this on my TODO list, I'll try to find time in the weekend. |
start-mailserver.shstart-mailserver.sh
|
any news on your side @erik-wramner ? @fbartels have you had time? |
fbartels
left a comment
There was a problem hiding this comment.
Sorry, quite a large changeset and therefore not that easy to review. But in the end it looks like almost exclusively formatting changes and no functional changes (at least I cannot remember seeing one of those).
|
That's correct @fbartels. In the end, it's only a refactoring:) The only "major" changes are those where I substituted code, for example array=$(cat $THIS | tr ":" "\n")which is ugly and not robust became declare -a ARRAY
IFS=':'
read -r -a ARRAY < <(cat "${THIS}")which is more verbose, but There were similar changes here and there. The majority of line changes came from brace substitutions and PS: Thank's for approving. |
|
@erik-wramner I see you have very little time at hand, plus the PR is pretty big. I really understand this and I don't want to force you into reviewing these changes. If it's okay with you, just tell me: @fbartels already approved and the tests look good, so there should be no risk involved in merging this if you are okay with not having reviewed this one. What's your take on this? There is one more thing I'd really like to see: A new release. You already drafted one for |
|
I've approved the changes. I'll try to make a release this weekend provided that master is stable (i.e. no serious bugs reported). |
The Second Half
This one is rather a blue whale. I completely refactored
start-mailserver.sh. Therefore, it is now included intoshellcheck. This was indeed a slow decend into madness.Changes
start-mailserver.shTo Do
#shellcheck disable...comments as possibleMakefileto use/usr/bin/shellcheckPost Scriptum
@erik-wramner I accidentally merge-commited all commits from #1601; I will squash them next time. I'm sorry for the inconvenience.