Changes from #1599 without start-mailserver.sh#1601
Changes from #1599 without start-mailserver.sh#1601georglauterbach merged 9 commits intodocker-mailserver:masterfrom georglauterbach:master
start-mailserver.sh#1601Conversation
included all changes from the work on refactoring all scripts, but excluded one big script to make merging easier; replaced mapfile with read
georglauterbach
changed the title
start-mailserver.shstart-mailserver.sh
|
Another question for @erik-wramner unrelated to this PR: How do you guys deal with (very) old issues, where there was no action for a prolonged period of time? |
|
@aendeavor as you can see there are tons of old issues. My policy is to ask if the issue is still relevant. If there is no answer in one week I will close it with a comment that it can be reopened if needed. Good job on your part, I noticed that you closed many recently! I'm willing to merge this if you are ready. Or by all means merge it yourself! |
Great news. I have pushed another commit rounding things up adding tables of contents. I will wait for the tests to finish, then I'll merge it. I also added a label, |
3 participants
The First Half
This PR includes the first half of #1599, i.e. everything that is not
start-mailserver.sh.Changes
README.mdto clean this section up.travis.ymlwith Prettier and added shellcheck capabilitiestarget/(exceptstart-mailserver.sh)CONTRIBUTING.mdso everyone can and must adhere to consistent guidelinesstart-mailserver.shhad to be touched due to renaming of functionsWhat's new
Bash scripts are now streamlined and follow a certain paradigm where strictness is key.
TravisCI will now check scripts with shellcheck, and throws an error if warnings were found. Guidelines have been written to make coding more streamlined.
To-Do
Current Errors
None. Ready for review and merge.
Post Scriptum
Thank you very much @tomav for invinting me!