Fix sasl_password generation to allow passwords containing hashes#1570
Merged
erik-wramner merged 3 commits intodocker-mailserver:masterfrom Jul 16, 2020
Merged
Conversation
Contributor
|
One of the quota tests failed. Not sure if it was caused by your change, but it could be. Do the tests succeed if you run them locally? Feel free to push again (force push or make a nonsense change) to trigger a rebuild. If we get the same error again it must have been caused by the change, which otherwise looks good. |
Contributor
Author
|
Made a dummy change and pushed again. Works now. Will revert the dummy change and push again. |
Contributor
Author
|
Hmm... Failed again. Seems to be something indeterministic in the tests as the failing do not seem to have anything in common with the small change. I'd suggest merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request to allow postfix SASL account to contain hashes (#).