Skip to content

Update dovecot-ldap.conf.ext#1557

Merged
erik-wramner merged 2 commits intodocker-mailserver:masterfrom
ubenmackin:master
Jul 13, 2020
Merged

Update dovecot-ldap.conf.ext#1557
erik-wramner merged 2 commits intodocker-mailserver:masterfrom
ubenmackin:master

Conversation

@ubenmackin
Copy link
Copy Markdown
Contributor

add auth_bind = no so that it can be overridden via the env-mailserver file used by docker compose.

This is related to #1526

add auth_bind = no so that it can be overridden via the env-mailserver file used by docker compose. This is related to docker-mailserver#1526
@ubenmackin
Copy link
Copy Markdown
Contributor Author

As @guardiande mentions in #1526 auth_bind is needed for some setups. Setting a default of no, so it doesn't break the existing setup. But by having the value in the dovecot-ldap.conf.ext it should be overridable with a env variable like DOVECOT_AUTH_BIND.

@erik-wramner
Copy link
Copy Markdown
Contributor

Is this PR work in progress? You mention an env variable, but it is not there?

@guardiande
Copy link
Copy Markdown
Contributor

Is this PR work in progress? You mention an env variable, but it is not there?

From start-mailserver.sh

configomat.sh "DOVECOT_" "/etc/dovecot/dovecot-ldap.conf.ext"

So creating the container with (that's the variable you're missing, it's not part of the PR 😊)

environment:
      - DOVECOT_AUTH_BIND=yes

would allow for closing #1526

@ubenmackin
Copy link
Copy Markdown
Contributor Author

Ah, ok. I misunderstood. I didn't think we had to specify all environment variables up front, only if you needed it used in the container. So I didn't add this to the env file, so it would retain the current default behavior.

But I can update the env file to include it.

@guardiande
Copy link
Copy Markdown
Contributor

Ah, ok. I misunderstood. I didn't think we had to specify all environment variables up front, only if you needed it used in the container. So I didn't add this to the env file, so it would retain the current default behavior.

But I can update the env file to include it.

No, you don't have to include the variable in the env file. You did everything right. Only if someone - like me - wants to have auth_bind set to yes she would have to override the default setting (which is no) to yes by including the DOVECOT_AUTH_BIND variable set to yes in the environment.

add environment variable for DOVECOT_AUTH_BIND
@ubenmackin
Copy link
Copy Markdown
Contributor Author

Ah, ok. I misunderstood. I didn't think we had to specify all environment variables up front, only if you needed it used in the container. So I didn't add this to the env file, so it would retain the current default behavior.
But I can update the env file to include it.

No, you don't have to include the variable in the env file. You did everything right. Only if someone - like me - wants to have auth_bind set to yes she would have to override the default setting (which is no) to yes by including the DOVECOT_AUTH_BIND variable set to yes in the environment.

Ya, I noticed there were a few other DOVECOT_ variables that could be used, but were not specified (DOVECOT_USER_ATTRS, DOVECOT_PASS_ATTRS, and DOVECOT_DEFAULT_PASS_SCHEME). But since the AUTH_BIND wasn't defined in the dovecot ldap.conf, it couldn't be overridden with environment variable.

I just committed another change to add DOVECOT_AUTH_BIND to the env file, so if @erik-wramner wants to review now, I think this can be pulled.

@erik-wramner erik-wramner merged commit 1a085d4 into docker-mailserver:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants