Fix dovecot variable with whitespace#1547
Merged
erik-wramner merged 1 commit intodocker-mailserver:masterfrom Jun 28, 2020
Merged
Fix dovecot variable with whitespace#1547erik-wramner merged 1 commit intodocker-mailserver:masterfrom
erik-wramner merged 1 commit intodocker-mailserver:masterfrom
Conversation
Contributor
|
The tests fail. I don't think it is caused by your change, but unfortunately I can't trigger them manually, can you make a nonsense commit please? |
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Contributor
Author
|
Done, the CI is green now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Outhenin-Chalandre [email protected]
This fixes shell expansion for dovecot variables by adding quotes. I saw this bug while trying to use a ldap bind dn with a space in it.