Skip to content

New option DOVECOT_MAILBOX_FORMAT#1314

Merged
erik-wramner merged 2 commits intodocker-mailserver:masterfrom
gmasse:mailbox-format
Nov 6, 2019
Merged

New option DOVECOT_MAILBOX_FORMAT#1314
erik-wramner merged 2 commits intodocker-mailserver:masterfrom
gmasse:mailbox-format

Conversation

@gmasse
Copy link
Copy Markdown
Contributor

@gmasse gmasse commented Nov 3, 2019

Add a new option DOVECOT_MAILBOX_FORMATto set Dovecot mail_location accordingly.
Issue #1313

@erik-wramner
Copy link
Copy Markdown
Contributor

Looks good, two very minor things. One is the indentation for the case/esac block in the start script. I guess it mixes tabs and spaces because the code doesn't line up. Not a big deal but easy to fix.

The other is the readme. Perhaps you could add a note that the two new formats were added to docker-mailserver in November 2019 and should be considered experimental until they have been tested in the wild for a while? I don't expect problems, but one never knows and then at least prospective new users have been warned.

@gmasse
Copy link
Copy Markdown
Contributor Author

gmasse commented Nov 4, 2019

I agree @erik-wramner, I will fix and add the comment.
Why not creating a Testing branch? Master would continue to be fed with bugfixes and minor changes when Testing would integrate big changes and enhancements. My 2 cents ;)

@erik-wramner
Copy link
Copy Markdown
Contributor

We could do that, but most of the work consists of fixes that everyone should get and then latest followed by stable works well. The next big thing is the upgrade to buster and there is a separate branch for that.

@gmasse
Copy link
Copy Markdown
Contributor Author

gmasse commented Nov 4, 2019

Grr I am fighting to correctly push my updates...

@erik-wramner
Copy link
Copy Markdown
Contributor

Are you done, or still fighting?

@gmasse
Copy link
Copy Markdown
Contributor Author

gmasse commented Nov 4, 2019

PR is good now.
Test has failed; I suspect a race condition or something like that. I cannot easily identify the root cause.
@erik-wramner can you relaunch the build?

@erik-wramner
Copy link
Copy Markdown
Contributor

Restarted. That error is not one of the frequent ones, but I have seen it before. Let's see what happens!

@erik-wramner erik-wramner merged commit bcfbb0d into docker-mailserver:master Nov 6, 2019
@erik-wramner
Copy link
Copy Markdown
Contributor

It worked, I merged the changes. Thanks!

@gmasse gmasse deleted the mailbox-format branch November 11, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants