[Test] "remove privacy details of the sender" misbehavior#1293
Merged
erik-wramner merged 3 commits intodocker-mailserver:masterfrom Oct 16, 2019
gmasse:fix-test-remove-privacy
Merged
[Test] "remove privacy details of the sender" misbehavior#1293erik-wramner merged 3 commits intodocker-mailserver:masterfrom gmasse:fix-test-remove-privacy
erik-wramner merged 3 commits intodocker-mailserver:masterfrom
gmasse:fix-test-remove-privacy
Conversation
…avoid time-out on low perf system
gmasse
changed the title
Contributor
|
Thanks for the PR and sorry for being a bit slow. I'll try to find time to review this Tomorrow. |
Contributor
|
@gmasse the first commit seems fine, but why did you remove the travis notifications? I'm not using slack or gitter myself, but there may be others who do. I don't want to remove the notifications without first discussing it. If you remove that change I'll be happy to merge the rest. If you want to keep it, please move it to another PR and motivate why it should go (for example if it is broken). We can then get comments from the others before merging it. |
This reverts commit b204f7d.
Contributor
Author
My mistake. New PR done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #1292
Email body updated
test/test-files/email-templates/send-privacy-email.txtClamAV and SpamAssassin disabled during this test (not relevant for this test)