In another project I am using the following snippet in a Makefile (could be added to the recently added lint target):

grep -rIl '^#![[:blank:]]*/bin/\(bash\|sh\|zsh\)' \
        --exclude-dir=.git --exclude=*.sw? \
        | xargs shellcheck -x

I like the idea @fbartels - no need to update .travis.yml every time a new shell script is added.
I guess we could use your approach, but limit it to the directories that will be expected to host shell scripts related to this project?
My concern is breaking builds for shell syntax issues found in shell scripts that come with the base image or packages.

My concern is breaking builds for shell syntax issues found in shell scripts that come with the base image or packages.

as shellcheck is performed in the checked out directory it will check scripts that are then only part of the build docker image. The concern is valid though for files pulled in by git submodules (bats for example).

This was a good idea, but it seems to have stalled. Were there too many errors to fix?

This was a good idea, but it seems to have stalled. Were there too many errors to fix?

Unfortunately, I haven't been able to spend any more time on this PR. Happy for someone else to pick it up and take over. Otherwise i'll aim to continue the work later this year.

@j-marz I refactored setup.sh already, currently waiting for the Travis tests to finish. Would be nice to see you continuing 👍

@j-marz I've got time now, will tend to it.

Can be closed due to #1601