Fixed opendkim config on multiple nameservers#1218
Merged
erik-wramner merged 1 commit intodocker-mailserver:masterfrom Aug 9, 2019
Merged
Fixed opendkim config on multiple nameservers#1218erik-wramner merged 1 commit intodocker-mailserver:masterfrom
erik-wramner merged 1 commit intodocker-mailserver:masterfrom
Conversation
Contributor
|
The tests failed, but I don't think it was caused by this change. I've restarted them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having multiple nameservers set in
/etc/resolv.confcurrently results in a malformed opendkim configuration and opendkim performing a crash loop.Given the file
/etc/resolv.conf:The following
/etc/opendkim.confconfiguration lines are created on startup (which are malformed):This fix merges the multiple lines and delimits them using
,, just as opendkim requires: