Fix linting errors reported by hadolint#1211
Fix linting errors reported by hadolint#1211fbartels merged 3 commits intodocker-mailserver:masterfrom
Conversation
|
@erik-wramner @martin-schulze-vireso I tried to understand the test failure around opendkim, but it does not really make sense to me. The way I see it the test starts a new container based on the testing tab mounting a folder out of the local dataset and then complains that the mounted data is empty. When running the command locally it succeeds for me. Can one of you shine some light on this? |
|
Well, several commands use I'm getting mad at the "can't login as newly added user" error, it always works locally but fails often in Travis... Probably because Postfix and Dovecot have been restarted and are not ready, but I don't know if there is more to it. |
Continuation of docker-mailserver#1194 Signed-off-by: Felix Bartels <[email protected]>
Signed-off-by: Felix Bartels <[email protected]>
|
No, that error was consistent and while thinking about it I now also know why it happened (but fixed the paths for ls nonetheless). The Dockerfile was using a cd in between and I changed this to switching the workdir (since this is a best practice), but that also mean that after starting the container we were not in /, but in /usr/share/dovecot. I have now added another workdir switch locally. Will now add a linting task to the makefile. |
fix linting messages in other dockerfiles in this repo Signed-off-by: Felix Bartels <[email protected]>
|
Yay, its finally green! Lets see if it stays green with the linting part of the testing. (this pr should be squashed before merging) |
Continuation of #1194
Signed-off-by: Felix Bartels [email protected]