Skip to content

Fix linting errors reported by hadolint#1211

Merged
fbartels merged 3 commits intodocker-mailserver:masterfrom
fbartels:hadolintv2
Aug 13, 2019
Merged

Fix linting errors reported by hadolint#1211
fbartels merged 3 commits intodocker-mailserver:masterfrom
fbartels:hadolintv2

Conversation

@fbartels
Copy link
Copy Markdown
Member

@fbartels fbartels commented Aug 6, 2019

Continuation of #1194

Signed-off-by: Felix Bartels [email protected]

@fbartels
Copy link
Copy Markdown
Member Author

@erik-wramner @martin-schulze-vireso I tried to understand the test failure around opendkim, but it does not really make sense to me.

The way I see it the test starts a new container based on the testing tab mounting a folder out of the local dataset and then complains that the mounted data is empty. When running the command locally it succeeds for me. Can one of you shine some light on this?

@erik-wramner
Copy link
Copy Markdown
Contributor

Well, several commands use ls -1 etc/opendkim which works in the root folder, but not elsewhere. Perhaps it would help to use /etc/opendkim instead? Is this error consistent, or does it come and go?

I'm getting mad at the "can't login as newly added user" error, it always works locally but fails often in Travis... Probably because Postfix and Dovecot have been restarted and are not ready, but I don't know if there is more to it.

@fbartels
Copy link
Copy Markdown
Member Author

No, that error was consistent and while thinking about it I now also know why it happened (but fixed the paths for ls nonetheless). The Dockerfile was using a cd in between and I changed this to switching the workdir (since this is a best practice), but that also mean that after starting the container we were not in /, but in /usr/share/dovecot.

I have now added another workdir switch locally.

Will now add a linting task to the makefile.

fix linting messages in other dockerfiles in this repo

Signed-off-by: Felix Bartels <[email protected]>
@fbartels
Copy link
Copy Markdown
Member Author

Yay, its finally green!

Lets see if it stays green with the linting part of the testing.

(this pr should be squashed before merging)

@fbartels fbartels merged commit 1ba0991 into docker-mailserver:master Aug 13, 2019
@fbartels fbartels deleted the hadolintv2 branch August 13, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants