WIP: fix linting errors reported by hadolint#1194
Closed
fbartels wants to merge 11 commits intodocker-mailserver:masterfrom
Closed
WIP: fix linting errors reported by hadolint#1194fbartels wants to merge 11 commits intodocker-mailserver:masterfrom
fbartels wants to merge 11 commits intodocker-mailserver:masterfrom
Conversation
Contributor
|
I restarted the build multiple times but there are always 1 or 2 tests |
Contributor
|
Sorry, have not seen it's still a WIP. |
Signed-off-by: Felix Bartels <[email protected]>
Signed-off-by: Felix Bartels <[email protected]>
Signed-off-by: Felix Bartels <[email protected]>
Signed-off-by: Felix Bartels <[email protected]>
Signed-off-by: Felix Bartels <[email protected]>
…6 checking ssl: generated default cert works correctly Signed-off-by: Felix Bartels <[email protected]>
Signed-off-by: Felix Bartels <[email protected]>
Signed-off-by: Felix Bartels <[email protected]>
Signed-off-by: Felix Bartels <[email protected]>
Member
Author
|
With the last commit the tests should be green now. Apart from fixing hadolint warnings (and ignoring some others) I have added some todos to the code for items that should be refactored/changed. I would suggest to squash before merge. If you want I could also split todos from the linting. |
Member
Author
|
hm.. now there are test failures around opendkim. I am going to split my changes into multiple prs and am going to create issues for my todos. |
fbartels
added a commit
to fbartels/docker-mailserver
that referenced
this pull request
Aug 6, 2019
Continuation of docker-mailserver#1194 Signed-off-by: Felix Bartels <[email protected]>
Member
Author
|
Closing here since I already created the followup prs. |
fbartels
added a commit
to fbartels/docker-mailserver
that referenced
this pull request
Aug 8, 2019
Continuation of docker-mailserver#1194 Signed-off-by: Felix Bartels <[email protected]>
fbartels
added a commit
to fbartels/docker-mailserver
that referenced
this pull request
Aug 12, 2019
Continuation of docker-mailserver#1194 Signed-off-by: Felix Bartels <[email protected]>
fbartels
added a commit
to fbartels/docker-mailserver
that referenced
this pull request
Aug 13, 2019
Continuation of docker-mailserver#1194 Signed-off-by: Felix Bartels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hadolint is a nice too to detect common pitfalls in Dockerfiles. If desired I can add it to the travis file as well.