1175: specify user for cron.d freshclam file#1176
Merged
tomav merged 4 commits intodocker-mailserver:masterfrom Jul 23, 2019
Merged
1175: specify user for cron.d freshclam file#1176tomav merged 4 commits intodocker-mailserver:masterfrom
tomav merged 4 commits intodocker-mailserver:masterfrom
Conversation
Contributor
Author
|
Merged in the fixed unit tests from my other pull request (dovecot fixes and root alias change script fix) so that the tests are green. It would be nice to get this in? |
Contributor
|
Thanks @erik-wramner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue 1175, cron complains that the freshclam entry in cron.d is invalid as it lacks a user. Fixed by adding root as user.
Note that the unit tests were failing before this, they are still failing after this and I don't really know how to test this with a unit test. A good manual test is to let the cron job run once with and without the fix. Without it there are errors in the logs and the cron job does not run.