Skip to content

bug report: CI failure for contributors.yml (_due to files with CRLF conflicting with .gitattributes_) #3565

@polarathene

Description

@polarathene

Description

The contributors.yml scheduled workflow recently failed which caught a mishap (my fault) with CRLF line endings committed in these files:

  • test/config/ldap/openldap/schemas/postfix-book.ldif
  • test/config/templates/dovecot-masters.cf
  • test/config/templates/postfix-accounts.cf

Insights:


Logs

Contributors failing workflow log

https://github.com/docker-mailserver/docker-mailserver/actions/runs/6287887262/job/17072802215#step:6:53

Create or update the pull request branch
  /usr/bin/git symbolic-ref HEAD --short
  master
  Working base is branch 'master'
  /usr/bin/git checkout --progress -B 7a7933b5-ccd5-4ecd-8447-70a6b72ee885 HEAD --
  Switched to a new branch '7a7933b5-ccd5-4ecd-8447-70a6b72ee885'
  M	test/config/ldap/openldap/schemas/postfix-book.ldif
  M	test/config/templates/dovecot-masters.cf
  M	test/config/templates/postfix-accounts.cf
  /usr/bin/git status --porcelain -unormal --
   M test/config/ldap/openldap/schemas/postfix-book.ldif
   M test/config/templates/dovecot-masters.cf
   M test/config/templates/postfix-accounts.cf
  Uncommitted changes found. Adding a commit.
  /usr/bin/git add -A
  warning: in the working copy of 'test/config/ldap/openldap/schemas/postfix-book.ldif', CRLF will be replaced by LF the next time Git touches it
  warning: in the working copy of 'test/config/templates/dovecot-masters.cf', CRLF will be replaced by LF the next time Git touches it
  warning: in the working copy of 'test/config/templates/postfix-accounts.cf', CRLF will be replaced by LF the next time Git touches it
  /usr/bin/git -c author.name=github-actions[bot] -c author.email=41898282+github-actions[bot]@users.noreply.github.com -c committer.name=github-actions[bot] -c committer.email=41898282+github-actions[bot]@users.noreply.github.com commit -m docs: update `CONTRIBUTORS.md` --signoff
  [7a7933b5-ccd5-4ecd-8447-70a6b72ee885 3[57](https://github.com/docker-mailserver/docker-mailserver/actions/runs/6287887262/job/17072802215#step:6:63)8b7b] docs: update `CONTRIBUTORS.md`
   3 files changed, 18 insertions(+), 18 deletions(-)

https://github.com/docker-mailserver/docker-mailserver/actions/runs/6287887262/job/17072802215#step:6:487

  From https://github.com/docker-mailserver/docker-mailserver
   * [new branch]        contributors-update -> origin/contributors-update
  Pull request branch 'contributors-update' already exists as remote branch 'origin/contributors-update'
  /usr/bin/git checkout --progress contributors-update --
  Switched to branch 'contributors-update'
  M	test/config/ldap/openldap/schemas/postfix-book.ldif
  M	test/config/templates/dovecot-masters.cf
  M	test/config/templates/postfix-accounts.cf
  /usr/bin/git rev-list --right-only --count master...7a7933b5-ccd5-4ecd-8447-70a6b72ee885
  1
  /usr/bin/git rev-list --right-only --count master...contributors-update
  0
  /usr/bin/git diff --quiet contributors-update..7a7933b5-ccd5-4ecd-8447-70a6b72ee885
  Resetting 'contributors-update'
  /usr/bin/git checkout --progress -B contributors-update 7a7933b5-ccd5-4ecd-8447-70a6b72ee885 --
  error: Your local changes to the following files would be overwritten by checkout:
  	test/config/ldap/openldap/schemas/postfix-book.ldif
  	test/config/templates/dovecot-masters.cf
  	test/config/templates/postfix-accounts.cf
  Please commit your changes or stash them before you switch branches.
  Aborting
  Error: The process '/usr/bin/git' failed with exit code 1
Example of ECLint successfully catching this rule elsewhere

Workflow log:
https://github.com/docker-mailserver/docker-mailserver/actions/runs/6070286374/job/16466057026#step:5:24

Status: Downloaded newer image for mstruebing/editorconfig-checker:2.7.0
target/features/ldap/dovecot.base:
	Wrong line endings or no final newline
	Not all lines have the correct end of line character
target/features/ldap/dovecot.tmpl:
	Wrong line endings or no final newline
	Not all lines have the correct end of line character
target/features/ldap/postfix.base:
	Wrong line endings or no final newline
	Not all lines have the correct end of line character
target/features/ldap/postfix.tmpl:
	Wrong line endings or no final newline
	Not all lines have the correct end of line character
target/features/ldap/saslauthd.base:
	Wrong line endings or no final newline
	Not all lines have the correct end of line character
target/features/ldap/saslauthd.tmpl:
	Wrong line endings or no final newline
	Not all lines have the correct end of line character

12 errors found
[  ERROR  ]  ECLint failed
make: *** [Makefile:76: eclint] Error 1

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions