Skip to content

bug report: Rspamd dkim_signing module should have try_fallback = false ? #3433

@Codelica

Description

@Codelica

📝 Preliminary Checks

  • I tried searching for an existing issue and followed the debugging docs advice, but still need assistance.

👀 What Happened?

I'm not an rspamd expert by any means, but was noticing that rspamd seemed to be trying to sign (DKIM) every message -- not just outbound email from local domains. For example if an inbound email from Gmail came, I'd something like this would be logged:

7/19/2023, 11:35:42 AM rspamd_proxy 1295 proxy b2bf53 cannot load dkim key /var/lib/rspamd/dkim/gmail.com.dkim.key: cannot stat key file: '/var/lib/rspamd/dkim/gmail.com.dkim.key' No such file or directory

After some Googling, I came across this issue which basically says that's the expected result if try_fallback = true which seems to be the default currently:

rspamd/rspamd#2832

Perhaps that should be set to false ? I did so in my override.d/dikim_signing.conf and the issue seems to have dissapeared without any repercussions that I can tell.

👟 Reproduction Steps

  • Enable rspamd
  • Send inbound email from external domains
  • Check history/error log for spamd

🐋 DMS Version

v12.1.0

💻 Operating System and Architecture

Debian 11

⚙️ Container configuration files

N/A but can provided if needed

📜 Relevant log output

7/19/2023, 11:35:42 AM	rspamd_proxy	1295	proxy	b2bf53	cannot load dkim key /var/lib/rspamd/dkim/gmail.com.dkim.key: cannot stat key file: '/var/lib/rspamd/dkim/gmail.com.dkim.key' No such file or directory
7/19/2023, 11:26:55 AM	rspamd_proxy	1294	proxy	d6988d	cannot load dkim key /var/lib/rspamd/dkim/linkedin.com.dkim.key: cannot stat key file: '/var/lib/rspamd/dkim/linkedin.com.dkim.key' No such file or directory
... ETC ...

Metadata

Metadata

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions