Skip to content

[BUG] _shutdown will continue when called in a subshell (causing UB) #3140

@polarathene

Description

@polarathene

Description

Not too important.

A user showed a particular failure scenario where shutdown was called twice, and additionally two sedfile errors that came afterwards, but it should have stopped from the first shutdown.

The function involved likely continues running instead of exiting early on failure. This may be the case for other scripts that invoke shutdown on failure. A workaround could just involve the logger being aware of the shutdown call to silence it's logging from then on? 🤷‍♂️

Or we can just leave it as-is. I believe there's some desired changes in future for running bash scripts that handle failure better? Or the potential that we migrate away from bash scripts.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions