-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[TODO] Improve supervisor test coverage #3119
Copy link
Copy link
Open
Labels
area/testskind/improvementImprove an existing feature, configuration file or the documentationImprove an existing feature, configuration file or the documentationmeta/help wantedThe OP requests help from others - chime in! :DThe OP requests help from others - chime in! :Dpriority/lowstale-bot/ignoreIndicates that this issue / PR shall not be closed by our stale-checking CIIndicates that this issue / PR shall not be closed by our stale-checking CI
Description
Metadata
Metadata
Assignees
Labels
area/testskind/improvementImprove an existing feature, configuration file or the documentationImprove an existing feature, configuration file or the documentationmeta/help wantedThe OP requests help from others - chime in! :DThe OP requests help from others - chime in! :Dpriority/lowstale-bot/ignoreIndicates that this issue / PR shall not be closed by our stale-checking CIIndicates that this issue / PR shall not be closed by our stale-checking CI
Description
As described in #3118 (comment) the supervisor tests (at the linked line location) could be improved to better catch changes that aren't compatible with management via
supervisord.Should mostly involve looping through a list of service names associated to equivalent processes checked in the linked test. Those can be found in this supervisor config (there is also SASLAUTHD in a separate config, but I'm not too fussed about that as we effectively only use the one for LDAP and another test for
rimap, it's unclear how many users use SASLAUTHD for anything beyond LDAP support however).Up for grabs for anyone who'd like to contribute, no rush :)