Skip to content

Makefile job 'backup' broken #2465

@casperklein

Description

@casperklein

Description

Since we renamed config to config-examples, this Makefile job no longer works:

backup:
# if backup directories exist, clean hasn't been called, therefore
# we shouldn't overwrite it. It still contains the original content.
-@ [[ ! -d config.bak ]] && cp -rp config config.bak || :
-@ [[ ! -d testconfig.bak ]] && cp -rp test/config testconfig.bak || :

--> cp: cannot stat 'config': No such file or directory

backup is part of the all job, so there is an error every time make all is run.

Anyway, there is no reliable way to detect the config directory someone might use, when no container is running. I am not sure, how useful a hard-coded config directory is at all.

Should we fix the job? How?
Or maybe remove that part of the job (Line 19)?

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/questionSomeone asked a question - feel free to answermeta/help wantedThe OP requests help from others - chime in! :Dmeta/needs triageThis issue / PR needs checks and verification from maintainerspriority/low

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions