-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[FR] Streamline alias code #1721
Copy link
Copy link
Open
Labels
area/scriptskind/improvementImprove an existing feature, configuration file or the documentationImprove an existing feature, configuration file or the documentationmeta/help wantedThe OP requests help from others - chime in! :DThe OP requests help from others - chime in! :Dpriority/lowstale-bot/ignoreIndicates that this issue / PR shall not be closed by our stale-checking CIIndicates that this issue / PR shall not be closed by our stale-checking CI
Metadata
Metadata
Assignees
Labels
area/scriptskind/improvementImprove an existing feature, configuration file or the documentationImprove an existing feature, configuration file or the documentationmeta/help wantedThe OP requests help from others - chime in! :DThe OP requests help from others - chime in! :Dpriority/lowstale-bot/ignoreIndicates that this issue / PR shall not be closed by our stale-checking CIIndicates that this issue / PR shall not be closed by our stale-checking CI
In a recent issue we discussed how the alias file is created and then updated and how the startup script and change detector modifies not only the alias file in the container, but also the mounted configuration files for accounts and aliases. We should find a cleaner solution where the mounted files can be read only and where system accounts can be added if not already present.
The new solution should ideally allow the mounted files to be mounted read only (though of course they need to be read-write when accessed by the setup script). We could also look into the locking that is done in the start script and change detector script to avoid concurrent access - that needs to be taken into account. It is not good enough to handle concurrent access inside the container, the mounted files can also be changed outside the container. The current lock tries to handle that.