Skip to content

[Test] "remove privacy details of the sender" misbehavior #1292

@gmasse

Description

@gmasse

Test email test/test-files/email-templates/send-privacy-email.txtis recognized as SPAM.
Also, a race condition can happen on low perf system and the test can time-out.

Actual Behavior

Test email is recognized as SPAM:

X-Spam-Status: Yes, score=3.961 tag=-5 tag2=2 kill=3
	tests=[BODY_SINGLE_WORD=0.689, DKIM_ADSP_NXDOMAIN=0.8,
	DKIM_SIGNED=0.1, NO_DNS_FOR_FROM=0.379, NO_RECEIVED=-0.001,
	NO_RELAYS=-0.001, PYZOR_CHECK=1.985, T_DKIM_INVALID=0.01]
	autolearn=no autolearn_force=no

The test succeeds because a bounce email is sent to the sender (same than recipient): [email protected]

Also, on low perf system, the test can time-out. It is due to slow start of ClamAV, delaying the delivery of test email, and causing exception on the line:
repeat_until_success_or_timeout 120 docker exec mail_privacy /bin/sh -c '[ $(ls /var/mail/localhost.localdomain/user1/new | wc -l) -eq 1 ]'

Possible Fix

Change content of the test email. Disable ClamAV for this specific test. PR #1293

Your Environment

  • Amount of RAM available: 8GB
  • Mailserver version used: master (711a3f8)
  • Docker version used: 19.03.3
  • Any relevant stack traces ("Full trace" preferred):
 ✗ checking postfix: remove privacy details of the sender
   (from function `repeat_until_success_or_timeout' in file test/test_helper/common.bash, line 23,
    in test file test/mail_privacy.bats, line 49)
     `repeat_until_success_or_timeout 120 docker exec mail_privacy /bin/sh -c '[ $(ls /var/mail/localhost.localdomain/user1/new | wc -l) -eq 1 ]'' failed
   depth=0 CN = 0e63f584403a
   verify return:1
   250 DSN
   250-mail.my-domain.com
   250-PIPELINING
   250-SIZE 10240000
   250-ETRN
   250-AUTH PLAIN LOGIN
   250-AUTH=PLAIN LOGIN
   250-ENHANCEDSTATUSCODES
   250-8BITMIME
   250 DSN
   334 UGFzc3dvcmQ6
   235 2.7.0 Authentication successful
   250 2.1.0 Ok
   250 2.1.5 Ok
   354 End data with <CR><LF>.<CR><LF>
   250 2.0.0 Ok: queued as DDB1E2F5F3C
   221 2.0.0 Bye
   Timed out on command: docker exec mail_privacy /bin/sh -c [ $(ls /var/mail/localhost.localdomain/user1/new | wc -l) -eq 1 ]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions