Update examples from "ruby:3.0" to "ruby:3.3" #2463
Conversation
Previous: docker-library#2051 3.0 images are not build/updated anymore
whalelines
left a comment
whalelines
left a comment
There was a problem hiding this comment.
Thanks for the update! A couple thoughts
|
|
||
| ```dockerfile | ||
| FROM %%IMAGE%%:3.0 | ||
| FROM %%IMAGE%%:3.3 |
There was a problem hiding this comment.
Perhaps it would be better to just use the latest tag in these examples?
There was a problem hiding this comment.
Using an explicit version was intentional so that we're modelling the appropriate behavior for end-users who shouldn't be pinning to :latest here -- this is a persistent issue though that we've considered changing our template engine for so that we could have a per-image calculation of this "best example tag" value. (Barring that, IMO this change is correct ❤️)
|
|
||
| ```console | ||
| $ docker run --rm -v "$PWD":/usr/src/app -w /usr/src/app %%IMAGE%%:3.0 bundle install | ||
| $ docker run --rm -v "$PWD":/usr/src/app -w /usr/src/app %%IMAGE%%:3.3 bundle install |
There was a problem hiding this comment.
It definitely seems safe to use the latest tag on the CLI.
There was a problem hiding this comment.
Since this generates/updates an artifact that users are supposed to commit to their Git repository, I think I might actually disagree -- users ought to be explicit about which version they're targeting/supporting. 😇
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
(approving, but not merging yet since I am open to discussion/convincing on the points where I've disagreed ❤️)
4 participants
Previous: #2051
3.0 images are not build/updated anymore
In a separate commit, I've dropped mentions of evn variables that were once set but aren't anymore. See docker-library/ruby#209 and docker-library/ruby#306