Ditch a lot of "--link" examples (using "--network some-network" instead to force users to do more homework)#1441
Merged
yosifkit merged 2 commits intodocker-library:masterfrom Mar 15, 2019
Conversation
…ead to force users to do more homework)
yosifkit
requested changes
Mar 12, 2019
Member
yosifkit
left a comment
yosifkit
left a comment
There was a problem hiding this comment.
Just some notes on cassandra. Maybe needs to drop the whole docker inspect subshell option too? 😢
cassandra/content.md
Outdated
|
|
||
| ```console | ||
| $ docker run --name some-cassandra2 -d --link some-cassandra:cassandra %%IMAGE%%:tag | ||
| $ docker run --name some-cassandra2 -d --network some-network %%IMAGE%%:tag |
Member
There was a problem hiding this comment.
This line won't create a cluster now; using link was correct, since cassandra took advantage of the link variables (https://github.com/docker-library/cassandra/blob/386357f2c90e5a53ad26f610cdc0eb001a67e9f0/3.11/docker-entrypoint.sh#L54-L56).
Member
There was a problem hiding this comment.
Suggested change
| $ docker run --name some-cassandra2 -d --network some-network %%IMAGE%%:tag | |
| $ docker run --name some-cassandra2 -d --network some-network -e CASSANDRA_SEEDS=some-cassandra %%IMAGE%%:tag |
yosifkit
approved these changes
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes docker-library/mysql#545