Explicitly set --oom-score-adjust to -500#258
Explicitly set --oom-score-adjust to -500#258thaJeztah wants to merge 1 commit intodocker-library:masterfrom
Conversation
Currently, dockerd sets a "-500" oom-score-adjust for itself by default. We're removing this default, and instead: - for dockerd running as systemd unit, set the oom-score through systemd - when manually running dockerd, require users to explicitly set a score This patch is in preparation of those changes. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
|
Hmm, given there are a number of cases where neither of these lines will be used (such as Edit: actually probably makes sense to link to docker/docker-ce-packaging#501 instead, since it gives the actual justification for why the change was made 😅 |
|
Good one, yeah, I was wondering what would be best; keep a default, or don't set a default at all. Given that it's running inside a container, users could even set the score of the container itself I guess 🤔 |
|
@cpuguy83 @AkihiroSuda wdyt? |
|
dind is also not likely something that is super critical. The reason we set oomscore on dockerd is because it is typically used as a critical system process. |
|
Agreed -- I really like the idea of documenting that it should be set on the container instead, especially since that nicely mirrors setting it in the systemd service. Maybe there are also other parameters in the systemd service we should document that users should set on their containers ( |
|
closing in favour of docker-library/docs#1821 |
3 participants
relates to moby/moby#41528
Currently, dockerd sets a "-500" oom-score-adjust for itself by default.
We're removing this default, and instead:
This patch is in preparation of those changes.