This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Fixes more issues swallowing connection errors#366
Merged
LK4D4 merged 1 commit intodocker-archive-public:masterfrom Aug 15, 2016
Merged
Fixes more issues swallowing connection errors#366LK4D4 merged 1 commit intodocker-archive-public:masterfrom
LK4D4 merged 1 commit intodocker-archive-public:masterfrom
Conversation
Really need to make sure we are only returning `ErrConnectionFailed` when it's really a failed connection, not just something that reports as a non-temporary error. This fixes more tests on docker CI. Signed-off-by: Brian Goff <[email protected]>
Contributor
|
LGTM 🐵 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really need to make sure we are only returning
ErrConnectionFailedwhen it's really a failed connection, not just something that reports as
a non-temporary error.
This fixes more tests on docker CI, see https://jenkins.dockerproject.org/job/Docker-PRs/31060/console for reference