This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Add config parameter to change per-container stop timeout during daemon shutdown#256
Merged
coolljt0725 merged 1 commit intodocker-archive-public:masterfrom Jun 3, 2016
yongtang:22471-daemon-shutdown-timeout
Merged
Add config parameter to change per-container stop timeout during daemon shutdown#256coolljt0725 merged 1 commit intodocker-archive-public:masterfrom yongtang:22471-daemon-shutdown-timeout
coolljt0725 merged 1 commit intodocker-archive-public:masterfrom
yongtang:22471-daemon-shutdown-timeout
Conversation
…on shutdown This fix tries to add a `StopTimeout` in container's Config so that a per-container stop timeout could be specified during daemon shutdown. The `StopTimeout` is defined as `*int` so that unspecified value could be correctly identified as using the default value (10s). Note: Both `0` and `-1` could not be used as the default value because `0` means stop immediately and `-1` means wait forever. This fix is related to docker: moby/moby#22566 Signed-off-by: Yong Tang <[email protected]>
Contributor
|
LGTM 🐮 |
Contributor
|
LGTM |
yongtang
added a commit
to yongtang/docker
that referenced
this pull request
Jun 3, 2016
This fix tries to update engine-api to 5d8739372315f8147ceb7bcc53576893ff96ffc6 This fix brings engine-api up to date, which includes changes from: docker-archive-public/docker.engine-api#256 docker-archive-public/docker.engine-api#254 This fix is related to Signed-off-by: Yong Tang <[email protected]>
Contributor
|
"Make the zero-value useful" Could we please stop adding needless pointer values everywhere? This is getting tiresome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix tries to add a
StopTimeoutin container's Config so that a per-container stop timeout could be specified during daemon shutdown.The
StopTimeoutis defined as*intso that unspecified value could be correctly identified as using the default value (10s).Note: Both
0and-1could not be used as the default value because0means stop immediately and-1means wait forever.This fix is related to docker:
moby/moby#22566
Signed-off-by: Yong Tang [email protected]