add parameter to Set api#441
Conversation
We only have libcontainer.Container on Docker side, can't change `config` in linuxContainer, pass config to libcontainer so we can change config of container. Signed-off-by: Qiang Huang <[email protected]>
There was a problem hiding this comment.
This gives me the assumption that the API allows us to change any of the configuration, while it probably only makes sense to change the cgroup limits (and possibly rlimits ).
Do you think we should define a subset of configuration (i.e. cgroup values, rlimits etc. ) that can be changed for a running container instead of reusing Config here ?
There was a problem hiding this comment.
I think Set could have more functionality in future to cover more than cgroups, so taking in the entire config makes sense to me.
There was a problem hiding this comment.
Yes, I was intend to make Set more functionality, not just change resource configs. We can reusing Config in libcontainer, and leave it to Docker to decide which Config can be changed.
|
Hi, Set command from Docker side is out, moby/moby#11442 |
|
LGTM @crosbymichael @vmarmol ping |
|
LGTM |
1 similar comment
|
LGTM |
4 participants
We only have libcontainer.Container on Docker side, can't change
configin linuxContainer, pass config to libcontainer so we can change config of
container.
Signed-off-by: Qiang Huang [email protected]