Add "update-vendor.sh" script and vendor our current deps...#140
Add "update-vendor.sh" script and vendor our current deps...#140crosbymichael merged 2 commits intodocker-archive:masterfrom
Conversation
|
The circle of life |
|
You should put this stuff in the Makefile for updating and pulling deps. The Dockerfile does not work with this stuff |
|
Ah, will do, thanks ❤️ |
|
You're still OK with the actual update-vendor script being separate right? |
|
why not put it all in the makefile? |
|
Because it's 48 lines long... :) |
|
fine! |
|
I moved the Travis logic into the Makefile and it made it much cleaner (since make is designed for these sorts of things), and now the Dockerfile works again and Travis uses the same code from the Makefile now. |
|
... and of course Travis fails |
|
There we go. |
|
LGTM |
|
i wish i could see our file's changes in a different commit instead of 12k lines of green ;) |
|
FINE, whiner; give me a sec |
|
There, rebased into two commits. |
…er, since that'd make a circle) Also, updated .travis.yml to use the new "vendor" directory (since this is pretty pointless without that :D) Signed-off-by: Andrew Page <[email protected]>
Signed-off-by: Andrew Page <[email protected]>
|
Well you didn't have to do it now. I was just letting you know you did something wrong ;) |
|
crosbymeanie |
|
@tianon it's ok, you should feel good that I hold you to higher standards and only expect the best from you ;) |
|
True enough; ♥ |
|
LGTM |
1 similar comment
|
LGTM |
Add "update-vendor.sh" script and vendor our current deps...
4 participants
... (minus Docker, since that'd make a circle)
Also, updated .travis.yml to use the new "vendor" directory (since this is pretty pointless without that :D)