Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] docs/rootless.md: update#408

Merged
andrewhsu merged 1 commit intodocker-archive:19.03from
thaJeztah:19.03_backport_update_rootless_docs
Oct 28, 2019
Merged

[19.03 backport] docs/rootless.md: update#408
andrewhsu merged 1 commit intodocker-archive:19.03from
thaJeztah:19.03_backport_update_rootless_docs

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 20, 2019

backport of moby#40076

@AkihiroSuda @thaJeztah
docs/rootless.md: update
a8b454a 
Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit e76dea1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 19.03.5 milestone Oct 20, 2019
@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 20, 2019

@AkihiroSuda ptal

@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 21, 2019

Argh CI is using the wrong diff?

These commits do not have a proper 'Signed-off-by:' marker:
  - b4c03dd6338e0c320db669a198cf48001dfdd49b
  - f0f7020b5d11b3fc99e6df64efdf96e7019eb5ae

@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 21, 2019

and the commits it's complaining about actually have a sign off

b4c03dd

@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 21, 2019 •
edited
Loading

oh; actually, this one doesn't f0f7020 (#261)

because the cherry pick comment is after the sign off

@thaJeztah thaJeztah mentioned this pull request Oct 21, 2019
Merged
@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 21, 2019

oh! I think I know;

docker run --rm -v /home/ubuntu/workspace/engine_PR-408:/workspace alpine sh -c apk add --no-cache -q git bash && cd /workspace && hack/validate/dco

We're not passing it the VALIDATE_REPO and VALIDATE_BRANCH env-vars, so it does not yet have the fix from moby#40035

@thaJeztah thaJeztah mentioned this pull request Oct 21, 2019
Merged
@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 21, 2019

opened moby#40119 to fix that

@thaJeztah thaJeztah mentioned this pull request Oct 21, 2019
Merged
andrewhsu
andrewhsu approved these changes Oct 28, 2019
View reviewed changes
Copy link

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 83bcde8 into docker-archive:19.03 Oct 28, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_update_rootless_docs branch October 28, 2019 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

19.03.5

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @andrewhsu @AkihiroSuda