This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Fix flaky TestServiceWithDefaultAddressPoolInit#376
Merged
andrewhsu merged 3 commits intodocker-archive:19.03from Sep 24, 2019
Merged
Conversation
3 tasks
Member
Author
|
this is now failing because the 19.03 branch is broken, which will be fixed by #374, but that depends on this PR |
thaJeztah
force-pushed
the
19.03_backport_fix_flaky_addr_pool_init_test
branch
from
bfc8d9e to
4a7caca
Compare
Looks like TestServiceWithDefaultAddressPoolInit is failing randomly in CI. I am not able to reproduce the issue locally but this has been reported few times. So I tried to modify code and see if I can fix the random failure. Signed-off-by: selansen <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 88578aa) Signed-off-by: Sebastiaan van Stijn <[email protected]>
1.This commit replaces serviceRunningCount with swarm.RunningTasksCount to accurately check if the service is running with the accurate number of instances or not. serviceRunningCount was only checking the ServiceList and was not checking if the tasks were running or not This adds a safe barrier to execute docker network inspect commands for overlay networks which get created asynchronously via Swarm 2. Make sure client connections are closed 3. Make sure every service and network name is unique 4. Make sure services and networks are cleaned up Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit f3a3ea0) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit a65dee3) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
19.03_backport_fix_flaky_addr_pool_init_test
branch
from
4a7caca to
218af8c
Compare
thaJeztah
changed the title
andrewhsu
approved these changes
Sep 24, 2019
andrewhsu
left a comment
andrewhsu
left a comment
There was a problem hiding this comment.
LGTM
failure on ppc64le only because it ran out of time to get a new node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on top of #281Backports of