This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Revert docker/swarmkit#2804#252
Merged
andrewhsu merged 1 commit intodocker-archive:19.03from Jun 4, 2019
Merged
[19.03 backport] Revert docker/swarmkit#2804#252andrewhsu merged 1 commit intodocker-archive:19.03from
andrewhsu merged 1 commit intodocker-archive:19.03from
Conversation
Reverts the change to swarmkit that made all updates set UpdateStatus to Completed Signed-off-by: Drew Erny <[email protected]> (cherry picked from commit c7d9599) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
ping @dperny @andrewhsu ptal |
|
thank you sebastiaan 🙌 |
|
windows failure is almost certainly unrelated |
Member
Author
|
Yes, RS1 failure is unrelated, and being looked at |
thaJeztah
changed the title
Member
Author
|
WIP, waiting for upstream to be merged |
thaJeztah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of moby#39281 for 19.03.
Local changes applied cleanly, but the vendor.conf did not; fixed by changing
vendor.confto point to the bump_v19.03 branch (which includes moby/swarmkit#2863), and runningvndragain.- What I did
Reverts the change to swarmkit that made all updates set UpdateStatus to Completed.
See moby/swarmkit#2861
related: moby/swarmkit#2804, moby#38520
fixes moby/swarmkit#2861
fixes moby#39023
- How I did it
Returned the integration test to the way it was before