-
Notifications
You must be signed in to change notification settings - Fork 1.1k
set MemorySwappiness default value #1425
set MemorySwappiness default value #1425
Conversation
584cba3
to
56b7e28
Compare
@jimmyxian, Seems it works well!
Thanks very much! |
ping @docker/swarm-maintainers |
LGTM |
ping @vieux |
@jimmyxian shouldn't this be fixed in compose ? |
@vieux I think should fix in both compose \ docker \ swarm. |
when will this get merged? |
56b7e28
to
4523d6c
Compare
@johnjelinek Can you try this and see if it work. Thanks. |
de714dc
to
47ceeb4
Compare
@jimmyxian: I don't think I can test this until there's a container for it. I'm not set up to build golang apps yet in my cluster. |
I must've done something wrong. I did a |
@jimmyxian: I also tried merging your branch into master in my local repo of swarm:master. Same problem. What should I do to ensure that it's tracking an updated commit hash? |
@johnjelinek Did you restart your Swarm Manager too with the new Image/binary including the commit? From your comment I read that you tried only with Swarm Agents. You mostly need to restart the Swarm Manager. So restarting it (hopefully) should do the trick :) |
Hrmm ... I'll give that a shot. I have the swarm manager running in HA mode with consul. Not sure if that makes a difference. — On Thu, Dec 3, 2015 at 5:25 PM, Alexandre Beslic [email protected]
|
@abronan: that was it :) all fixed now. |
@johnjelinek Woop! Thanks a lot for testing and confirming :) Let's include the fix asap. PTAL @docker/swarm-maintainers |
@johnjelinek Thanks for testing. :) |
Signed-off-by: Xian Chaobo <[email protected]>
47ceeb4
to
63498b1
Compare
@jimmyxian / @abronan: do you have an ETA on when this might get merged/published? I feel nervous running all these processes outside of docker containers. |
LGTM |
…value set MemorySwappiness default value
@johnjelinek Hey, you can run the This will be published in 1.0.1 sometime next week. |
@aluzzardi: sweet, thanks! |
If I understand correctly, this fixes moby/moby#17879 ? |
Yes, that's correct. On Sun, Dec 6, 2015 at 4:39 AM, Sebastiaan van Stijn <
|
…iness-default-value set MemorySwappiness default value
Fix this issue: #1411
Signed-off-by: Xian Chaobo [email protected]