Allow to download staging releases of buildx#98
Allow to download staging releases of buildx#98crazy-max wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: CrazyMax <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
===========================================
- Coverage 71.53% 61.20% -10.34%
===========================================
Files 3 3
Lines 130 183 +53
Branches 22 27 +5
===========================================
+ Hits 93 112 +19
- Misses 28 57 +29
- Partials 9 14 +5
Continue to review full report at Codecov.
|
|
iiuc this pulls the buildx.zip from the workflow run in buildx repo. The problems with that are that this zip is huge and contains all platforms and afaics these artifacts are not there forever but github cleans them up based on repo configuration. I know even with cleanup we already use at least tens of GB to store them. As this would make the user workflow break at an arbitrary time I don't think anyone should use them. Maybe if you really want to use any commit buildx can be built directly. Or I guess you were thinking about storing these artifacts in docker images. |
Yes we can't download a per-platform artifact atm as everything is bundled in a single archive (actions/upload-artifact#138).
Yes it is. The purpose of this design is to be used for testing purpose but agree that breaking their workflow is not smth we want.
Yes now that we have our buildx-bin repo on Docker Hub I think I will use the Docker image. I also encounter an issue with the current impl. The |
|
I made a feat of upload artifact per file |
4 participants
Would allow to download an artifact from a specified pull request or runID from docker/buildx repo for testing purposes.
To do this, you need to define a special prefix in the
versioninput to lift this feature:- uses: docker/setup-buildx-action@v1 with: version: pr-645You can also directly specify a runID like
986572944:- uses: docker/setup-buildx-action@v1 with: version: runid-986572944Need some tests before merging.
cc @tonistiigi
Signed-off-by: CrazyMax [email protected]