preserve quotes surrounding fields in input list#174
Merged
crazy-max merged 1 commit intodocker:masterfrom Oct 18, 2022
Merged
Conversation
Signed-off-by: CrazyMax <[email protected]>
jedevc
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #173
In the toolkit api, args passed to exec are not quoted correctly: https://github.com/actions/toolkit/blob/9b58167dc9923ca0399b2451f4b3b2c6d4f25f3b/packages/exec/src/toolrunner.ts#L71-L77 as they are using
child_process.spawn().With Node.js spawn, double-quotes take precedence over single-quotes, so the spawn call breaks down. Looks like this has been solved when using a windows runner but not on linux.
To mitigate this issue we need to preserve quotes surrounding fields in input list.
Signed-off-by: CrazyMax [email protected]