Skip to content

docs(README): add a hint about multi-arch builds#359

Merged
dvdksn merged 1 commit intodocker:masterfrom
favonia:document-annotations
Nov 30, 2023
Merged

docs(README): add a hint about multi-arch builds#359
dvdksn merged 1 commit intodocker:masterfrom
favonia:document-annotations

Conversation

@favonia
Copy link
Copy Markdown
Contributor

@favonia favonia commented Nov 30, 2023

No description provided.

Copy link
Copy Markdown
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@favonia
Copy link
Copy Markdown
Contributor Author

favonia commented Nov 30, 2023

@dvdksn oops I didn't notice your approval and added more words. I hope it's okay.

@dvdksn
Copy link
Copy Markdown
Contributor

dvdksn commented Nov 30, 2023

@favonia addition looks good too :-) Please squash the commits

@favonia favonia force-pushed the document-annotations branch from 36d3cd6 to 2394fd6 Compare November 30, 2023 12:53
Document probably the most common usage of
`DOCKER_METADATA_ANNOTATIONS_LEVELS`: multi-arch builds.

Signed-off-by: favonia <[email protected]>
@favonia favonia force-pushed the document-annotations branch from 2394fd6 to 91224bc Compare November 30, 2023 12:53
@favonia
Copy link
Copy Markdown
Contributor Author

favonia commented Nov 30, 2023

Done! (PS: I'm excited about the new feature. 😀)

Copy link
Copy Markdown
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

PTAL @dvdksn

@crazy-max crazy-max requested a review from dvdksn November 30, 2023 14:28
@dvdksn dvdksn merged commit 26b4721 into docker:master Nov 30, 2023
@favonia favonia deleted the document-annotations branch November 30, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants