Allow building without systemd dependency#64
Merged
dave-tucker merged 1 commit intodocker:masterfrom Jan 30, 2017
Merged
Conversation
Collaborator
|
Why is this needed here? Isn't just ok to skip socket activation like it's currently happening (and like Docker or runc does? |
Contributor
Author
|
@runcom it's useful for being able to build a lightweight container plugin. With the systemd dependency there is a dependency on cgo at some point which prevents me from making a static binary. |
Collaborator
|
I see, tests are failing though |
Contributor
Author
|
@runcom it's failing because of moby/moby@b937aa8 |
tiborvass
commented
Nov 16, 2016
| // checks whether /run/systemd/system/ exists and is a directory. | ||
| // http://www.freedesktop.org/software/systemd/man/sd_booted.html | ||
| // | ||
| // Copied from github.com/coreos/go-systemd/util.IsRunningSystemd |
Contributor
Author
There was a problem hiding this comment.
Actually if we do this, we probably don't need to have build tags, but it'd be less dependencies with nosystemd tag.
dave-tucker
approved these changes
Jan 24, 2017
Contributor
dave-tucker
left a comment
dave-tucker
left a comment
There was a problem hiding this comment.
LGTM 🥇
@tiborvass would you mind rebasing?
Signed-off-by: Tibor Vass <[email protected]>
Contributor
Author
|
@dave-tucker @runcom rebased |
This was referenced Jun 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass [email protected]