Add graphdriver helpers #42
Conversation
Thanks to @dave-tucker for the original version of this patch (see. docker#33). I've changed the interface slightly to simplify the creation of new plugins and I've added some tests, inspired from the volume helpers. Signed-off-by: Thomas Gazagnaire <[email protected]>
Signed-off-by: Thomas Gazagnaire <[email protected]>
This is useful to test the package. Signed-off-by: Thomas Gazagnaire <[email protected]>
Untested with real drivers, but unit-test pass. Signed-off-by: Thomas Gazagnaire <[email protected]>
|
Oooh nice! |
|
LGTM |
|
LGTM Ping @calavera |
|
I think we changed the graphdriver interface to include a |
|
I've now added the shim layer to turn upstream drivers into plugins. There are some minor issues issues with the doc and the shim, not sure where it's the best place to report/fix that. For instance:
|
Rename PluginXRequest into CallX as this is simpler to use and describe. Signed-off-by: Thomas Gazagnaire <[email protected]>
Indeed. I'll open a PR in docker/docker to add this and fix inconsistencies and add that method call to my PR. |
Signed-off-by: Thomas Gazagnaire <[email protected]>
Signed-off-by: Thomas Gazagnaire <[email protected]>
|
Note: I still haven't tested that with a real graph driver so maybe that's not very wise to merge it immediately. |
|
@samoht did you manage to test with a real driver? If not, shall we merge anyway... we can always improve the code with real world testing later |
|
@dave-tucker no I haven't tested it yet. But yes, feel free to merge. |
5 participants
Thanks to @dave-tucker for the original version of this patch (see. #33). I've changed the interface slightly to simplify the creation of new plugins and I've added some tests, inspired from the volume helpers.
I have an other patch to add
shim.goso we can use built-in graphdrivers as plugins, I need to write some test first (and figure how I can test that properly).