Update Compose file reference for version 3#716
Conversation
|
Deploy preview ready! Built with commit 8524552 |
aanand
force-pushed
the
compose-file-v3
branch
from
57b2449 to
5cb6765
Compare
compose/compose-file.md
Outdated
| - data-volume:/var/lib/backup/data | ||
|
|
||
| volumes: | ||
| log-volume: |
aanand
force-pushed
the
compose-file-v3
branch
3 times, most recently
from
7676779 to
9519caf
Compare
|
Added docs for |
| test: ["CMD", "curl", "-f", "http://localhost"] | ||
| interval: 1m30s | ||
| timeout: 10s | ||
| retries: 3 |
There was a problem hiding this comment.
Don't we have disable: true as well?
There was a problem hiding this comment.
Good catch, I've added a note at the bottom and removed the test: ["NONE"] example.
| > `volume_driver`. | ||
| - No path expansion will be done if you have also specified a `volume_driver`. | ||
| For example, if you specify a mapping of `./foo:/data`, the `./foo` part | ||
| will be passed straight to the volume driver without being expanded. |
There was a problem hiding this comment.
I didn't know this was a thing we did.
There was a problem hiding this comment.
Yep, check out test_home_directory_with_driver_does_not_expand in config_test.py
Signed-off-by: Aanand Prasad <[email protected]>
aanand
force-pushed
the
compose-file-v3
branch
from
9519caf to
8524552
Compare
|
@mstanleyjones, @johndmulhausen this is an example of a file that deserves to have proper versioning. We should consider having a file for each compose file format. That way we can teach new users how to do things the new way so that they don't even learn the old format. |
|
LGTM |
|
Isn't this supposed to be updated for 1.13? If so, shouldn't we merge this in |
|
@dnephin @aanand @nathanleclaire did you want this merged into |
|
@aanand @londoncalling @dnephin @mstanleyjones I think we meant to do this in It should also be tracked against the Compose v1.10 milestone: https://github.com/docker/docker.github.io/milestone/5 So, one more revert, and one more re-do. Sorry. CC'ing @mstanleyjones because I'm not sure when the last time we rebased |
Add existing pages to UCP 3.0 (archiving 3.0 files to version-based archive directory)
5 participants
Currently a rough draft. This document will only be true once Engine 1.13 and Compose 1.10 are released.
TODO:
healthcheckstop_grace_period